Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1238783003: Handle deferred access as pre-step in SemanticSendVisitor. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/compiler/lib/src/resolved_visitor.dart ('K') | « pkg/compiler/lib/src/resolved_visitor.dart ('k') | tests/compiler/dart2js/proxy_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 133567486ff7df32adf2493e20b90bed4e0f285f..c877dae65b69d44eae0fdc4d60444c61a874f7cf 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -3417,6 +3417,11 @@ class SsaBuilder extends ast.Visitor
}
}
+ @override
+ void visitDeferredAccess(ast.Send node, PrefixElement prefix, _) {
+ generateIsDeferredLoadedCheckIfNeeded(prefix, node);
sigurdm 2015/07/20 07:52:21 Remove the check from all covered cases.
Johnni Winther 2015/07/20 08:53:53 Done.
+ }
+
/// Read a static or top level [field].
void generateStaticFieldGet(ast.Send node, FieldElement field) {
generateIsDeferredLoadedCheckOfSend(node);
« pkg/compiler/lib/src/resolved_visitor.dart ('K') | « pkg/compiler/lib/src/resolved_visitor.dart ('k') | tests/compiler/dart2js/proxy_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698