Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: Source/platform/fonts/FontPlatformDataTest.cpp

Issue 1238753005: Add unit tests for FontPlatformData::hasSpaceInLigaturesOrKerning (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase w/HEAD Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/platform/fonts/FontPlatformData.cpp ('k') | Source/platform/fonts/TestFontSelector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2015 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
11 * copyright notice, this list of conditions and the following disclaimer 11 * copyright notice, this list of conditions and the following disclaimer
12 * in the documentation and/or other materials provided with the 12 * in the documentation and/or other materials provided with the
13 * distribution. 13 * distribution.
14 * * Neither the name of Google Inc. nor the names of its 14 * * Neither the name of Google Inc. nor the names of its
15 * contributors may be used to endorse or promote products derived from 15 * contributors may be used to endorse or promote products derived from
16 * this software without specific prior written permission. 16 * this software without specific prior written permission.
17 * 17 *
18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 18 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 19 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 20 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 21 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 22 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "public/web/WebSelector.h" 32 #include "platform/fonts/Font.h"
33 33
34 #include "public/platform/WebString.h" 34 #include "platform/fonts/TestFontSelector.h"
35 #include "platform/fonts/TypesettingFeatures.h"
35 #include "public/platform/WebUnitTestSupport.h" 36 #include "public/platform/WebUnitTestSupport.h"
37
36 #include <gtest/gtest.h> 38 #include <gtest/gtest.h>
37 39
38 namespace blink { 40 namespace blink {
39 41
40 TEST(WebSelectorTest, Canonicalizes) 42 static inline String fontPath(String relativePath)
41 { 43 {
42 EXPECT_EQ("h1, h2[style=\"foobar\"] span", canonicalizeSelector("h1,h2[style ='foobar'] span").utf8()); 44 return Platform::current()->unitTestSupport()->webKitRootDir()
43 EXPECT_EQ("h1, h2[style=\"foobar\"] span", canonicalizeSelector("h1, h2[styl e=\"foobar\"] span").utf8()); 45 + String("/LayoutTests/")
46 + relativePath;
44 } 47 }
45 48
46 TEST(WebSelectorTest, Checks) 49 TEST(FontPlatformDataTest, AhemHasNoSpaceInLigaturesOrKerning)
47 { 50 {
48 EXPECT_EQ("", canonicalizeSelector("h1..h2").utf8()); 51 Font font = createTestFont("Ahem", fontPath("resources/Ahem.woff"));
49 EXPECT_EQ("", canonicalizeSelector("h1..h2", WebSelectorTypeCompound).utf8() ); 52 const FontPlatformData& platformData = font.primaryFont()->platformData();
53 TypesettingFeatures features = Kerning | Ligatures;
54
55 EXPECT_FALSE(platformData.hasSpaceInLigaturesOrKerning(features));
50 } 56 }
51 57
52 TEST(WebSelectorTest, Restricts) 58 TEST(FontPlatformDataTest, AhemSpaceLigatureHasSpaceInLigaturesOrKerning)
53 { 59 {
54 EXPECT_EQ("", canonicalizeSelector("h1 span,h2", WebSelectorTypeCompound).ut f8()); 60 Font font = createTestFont("AhemSpaceLigature",
55 EXPECT_EQ("h1, h2[style=\"foobar\"].cls", canonicalizeSelector("h1,h2[style= \"foobar\"].cls", WebSelectorTypeCompound).utf8()); 61 fontPath("third_party/AhemSpaceLigature/AhemSpaceLigature.woff"));
62 const FontPlatformData& platformData = font.primaryFont()->platformData();
63 TypesettingFeatures features = Kerning | Ligatures;
64
65 EXPECT_TRUE(platformData.hasSpaceInLigaturesOrKerning(features));
66 }
67
68 TEST(FontPlatformDataTest, AhemSpaceLigatureHasNoSpaceWithoutFontFeatures)
69 {
70 Font font = createTestFont("AhemSpaceLigature",
71 fontPath("third_party/AhemSpaceLigature/AhemSpaceLigature.woff"));
72 const FontPlatformData& platformData = font.primaryFont()->platformData();
73 TypesettingFeatures features = 0;
74
75 EXPECT_FALSE(platformData.hasSpaceInLigaturesOrKerning(features));
56 } 76 }
57 77
58 } // namespace blink 78 } // namespace blink
OLDNEW
« no previous file with comments | « Source/platform/fonts/FontPlatformData.cpp ('k') | Source/platform/fonts/TestFontSelector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698