Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 12387095: [nacltoons] Use box2d sensors to detect collisions. (Closed)

Created:
7 years, 9 months ago by Sam Clegg
Modified:
7 years, 9 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[nacltoons] Use box2d sensors to detect collisions. Also, roll cocos2dx version, now that our port has been upstreamed. BUG=None Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1516

Patch Set 1 : #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -62 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M nacltoons/data/res/loader.lua View 1 7 chunks +31 lines, -30 lines 0 comments Download
M nacltoons/data/res/sample_game/level1.lua View 1 chunk +16 lines, -9 lines 0 comments Download
M nacltoons/src/physics_layer.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M nacltoons/src/physics_layer.cc View 1 6 chunks +28 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
7 years, 9 months ago (2013-03-04 19:17:45 UTC) #1
binji
lgtm https://codereview.chromium.org/12387095/diff/3001/nacltoons/data/res/loader.lua File nacltoons/data/res/loader.lua (right): https://codereview.chromium.org/12387095/diff/3001/nacltoons/data/res/loader.lua#newcode131 nacltoons/data/res/loader.lua:131: for i = 1,num_children do won't this draw ...
7 years, 9 months ago (2013-03-04 19:31:13 UTC) #2
Sam Clegg
https://codereview.chromium.org/12387095/diff/3001/nacltoons/data/res/loader.lua File nacltoons/data/res/loader.lua (right): https://codereview.chromium.org/12387095/diff/3001/nacltoons/data/res/loader.lua#newcode131 nacltoons/data/res/loader.lua:131: for i = 1,num_children do On 2013/03/04 19:31:13, binji ...
7 years, 9 months ago (2013-03-04 20:08:18 UTC) #3
Sam Clegg
7 years, 9 months ago (2013-03-04 21:14:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r1516 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698