Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 12387092: Initialize bounds even if the text length is zero. (Closed)

Created:
7 years, 9 months ago by djsollen
Modified:
7 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Initialize bounds even if the text length is zero. Committed: https://code.google.com/p/skia/source/detail?r=7964

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/core/SkPaint.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/PaintTest.cpp View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
7 years, 9 months ago (2013-03-04 18:41:17 UTC) #1
reed1
code looks good, question about the test. https://codereview.chromium.org/12387092/diff/1/tests/PaintTest.cpp File tests/PaintTest.cpp (right): https://codereview.chromium.org/12387092/diff/1/tests/PaintTest.cpp#newcode108 tests/PaintTest.cpp:108: // test ...
7 years, 9 months ago (2013-03-04 19:11:47 UTC) #2
djsollen
https://codereview.chromium.org/12387092/diff/1/tests/PaintTest.cpp File tests/PaintTest.cpp (right): https://codereview.chromium.org/12387092/diff/1/tests/PaintTest.cpp#newcode108 tests/PaintTest.cpp:108: // test that the rect was initialized On 2013/03/04 ...
7 years, 9 months ago (2013-03-04 19:47:04 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 9 months ago (2013-03-04 19:47:17 UTC) #4
djsollen
7 years, 9 months ago (2013-03-04 19:47:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r7964 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698