Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: src/pdf/SkPDFDevice.cpp

Issue 12387086: Unwind PDFObject destructor calls into heap instead of stack. Notice: the order of the destructors … (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/pdf/SkPDFDevice.cpp
===================================================================
--- src/pdf/SkPDFDevice.cpp (revision 7963)
+++ src/pdf/SkPDFDevice.cpp (working copy)
@@ -644,8 +644,14 @@
fFontResources.unrefAll();
fShaderResources.unrefAll();
SkSafeUnref(fAnnotations);
- SkSafeUnref(fResourceDict);
+ // Transfer ownership of fResourceDict to list.
+ SkTDArray<SkPDFObject*> list;
+ list.push(fResourceDict);
+ fResourceDict = NULL;
+
+ SkPDFObject::safeUnref(&list);
+
if (clearFontUsage) {
fFontGlyphUsage->reset();
}

Powered by Google App Engine
This is Rietveld 408576698