Issue 12387076: MIPS: Minor cleanup of CompareIC state

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12387076: MIPS: Minor cleanup of CompareIC state (Closed)

Created:
7 years, 9 months ago by palfia

Modified:
7 years, 9 months ago

Reviewers:
kisg, Paul Lind, danno, rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.16

Visibility:
Public.

More Reviews

Description

MIPS: Minor cleanup of CompareIC state Port r13775 (1fd19d83) Original commit message: Allow transitioning from KNOWN_OBJECT to KNONW_OBJECT or OBJECT. Also, rename HEAP_NUMBER IC states to NUMBER, since they handle Smis, too. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13805

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed nits #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -17 lines)			Patch
	M	src/mips/code-stubs-mips.cc	View	1	10 chunks	+15 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rossberg

LGTM with nits https://codereview.chromium.org/12387076/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/12387076/diff/1/src/mips/code-stubs-mips.cc#newcode2700 src/mips/code-stubs-mips.cc:2700: : not_numbers; Nit: this looks like ...

7 years, 9 months ago (2013-03-04 14:03:11 UTC) #2

palfia

Uploaded new patchset. https://codereview.chromium.org/12387076/diff/1/src/mips/code-stubs-mips.cc File src/mips/code-stubs-mips.cc (right): https://codereview.chromium.org/12387076/diff/1/src/mips/code-stubs-mips.cc#newcode2700 src/mips/code-stubs-mips.cc:2700: : not_numbers; On 2013/03/04 14:03:11, rossberg ...

7 years, 9 months ago (2013-03-04 14:39:50 UTC) #3

Message was sent while issue was closed.

Committed manually as r13805 (presubmit successful).

Expand Messages | Collapse Messages