Add PPB_VarDictionary_Dev support - part 1.

ppapi/shared_impl/var_value_conversions.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef PPAPI_SHARED_IMPL_VAR_VALUE_CONVERSIONS_H_
+#define PPAPI_SHARED_IMPL_VAR_VALUE_CONVERSIONS_H_
+
+#include "ppapi/c/pp_var.h"
+#include "ppapi/shared_impl/ppapi_shared_export.h"
+
+namespace base {
+class Value;
+}
+
+namespace ppapi {
+
+// The caller takes ownership of the returned object.
+//
+// The conversion fails and returns NULL if
+// - |var| is undefined (PP_VARTYPE_UNDEFINED), or object (PP_VARTYPE_OBJECT);
+//   or
+// - |var| is an array or dictionary, and calling CreateValueFromVar() on any of
+//   the array elements or dictionary values fails; or
+// - there exist circular references, i.e., an array or dictionary is its own
+//   ancestor/descendant.
+PPAPI_SHARED_EXPORT base::Value* CreateValueFromVar(const PP_Var& var);

[dmichael (off chromium), 2013/03/05 22:01:03]

did you consider using scoped_ptr for the return to make the ownership
self-documenting?

[yzshen1, 2013/03/14 05:38:21]

I think that it is consistent with things such as
Value* CreateNullValue();
StringValue* CreateFilePathValue();
WDYT? :)

On 2013/03/05 22:01:03, dmichael wrote:

[dmichael (off chromium), 2013/03/15 17:35:48]

Sure, consistency is worthwhile. sgtm

+
+// The returned var has been added ref on behalf of the caller.
+// Returns an undefined var if the conversion fails.
+PPAPI_SHARED_EXPORT PP_Var CreateVarFromValue(const base::Value& value);
+
+}  // namespace ppapi
+
+#endif  // PPAPI_SHARED_IMPL_VAR_VALUE_CONVERSIONS_H_