Convert TrayVPN to use new NetworkState code

Update NetworkStateListDetailedView for VPN

BUG=179605
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186457

[stevenjb, 2013-03-02 03:14:45]

There is some necessary cleanup code with this, and a small amount of additional
cleanup that would be a bit tedious to extract out. I tried to explain the
cleanup in my comments.

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_icon.h (right):

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_icon.h:49: int
GetCellularUninitializedMsg();
Since network_icon handles most other network related messages (it could really
be named network_icon_and_text, but that's kind of a mouthful), this seemed like
as good a place as any for this. It's used by both NetworkStateListDetailedView,
which is not persistent, and by TrayNetwork, but NetworkStateListDetailedView no
longer knows details about TrayNetwork and might be spawned by TrayVpn.

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_state_list_detailed_view.cc (right):

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_state_list_detailed_view.cc:187:
CreateScrollableList();
This was in CreateMobileAccount for no good reason

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/network_state_list_detailed_view.h (right):

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/network_state_list_detailed_view.h:88: void
UpdateNetworkList();
There's already a UpdateNetworkListEntries, oops. This is a better name anyway.

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/tray_network.cc (left):

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/tray_network.cc:546: void
TrayNetwork::ConnectToNetwork(const std::string& service_path) {
The only reason this was here instead of NetworkStateListDetailedView was for
tracking connecting_networks_, so I moved the tracking to
TrayNetworkStateObserver which makes more sense anyway.

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/tray_network_state_observer.cc (left):

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/tray_network_state_observer.cc:37: wifi_state_ =
wifi_state;
This code was actually doing the wrong thing; we actually only want to popup
WIFI_VIEW (which is really a popup/notification) when a user initiated change
occurs while not in the status area, i.e. via a hotkey.

[jennyz, 2013-03-04 20:02:53]

lgtm for ash/system/chromeos/network with a minor nit.

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/tray_vpn.cc (right):

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/tray_vpn.cc:63: LOG(ERROR) << "First VPN: " << (vpn
? vpn->name() : std::string("None"));
Is this log message supposed to be here for error?

[stevenjb, 2013-03-04 20:41:32]

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
File ash/system/chromeos/network/tray_vpn.cc (right):

https://codereview.chromium.org/12387065/diff/2001/ash/system/chromeos/networ...
ash/system/chromeos/network/tray_vpn.cc:63: LOG(ERROR) << "First VPN: " << (vpn
? vpn->name() : std::string("None"));
On 2013/03/04 20:02:53, jennyz wrote:
> Is this log message supposed to be here for error?
Oops. Removed.

[stevenjb, 2013-03-05 00:14:04]

gspencer@ - can you look at the chromeos/networ changes (to stubs and tests)?
Thanks.

[Greg Spencer (Chromium), 2013-03-05 19:06:49]

lgtm

[commit-bot: I haz the power, 2013-03-05 19:16:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12387065/16001

[commit-bot: I haz the power, 2013-03-05 19:24:05]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-05 22:57:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevenjb@chromium.org/12387065/35001

[stevenjb, 2013-03-06 17:42:31]

Committed patchset #9 manually as r186457 (presubmit successful).