Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 12387046: Merge 184868 (Closed)

Created:
7 years, 9 months ago by erikwright (departed)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, darin-cc_chromium.org, sail+watch_chromium.org
Visibility:
Public.

Description

Merge 184868 > Make SQLitePersistentCookieStore run on injected SequencedTaskRunners vs named BrowserThreads. > > In a follow-up, I will make the production code run on the worker pool, which will hopefully speed up browser startup by eliminating delays due to other long-running DB thread tasks. > > R=rdsmith@chromium.org > TBR=jar@chromium.org,mmenke@chromium.org > BUG=175415 > > > Review URL: https://chromiumcodereview.appspot.com/12314015 TBR=erikwright@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185573

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -203 lines) Patch
M base/base.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store.cc View 28 chunks +130 lines, -108 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store_perftest.cc View 3 chunks +33 lines, -18 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc View 8 chunks +48 lines, -73 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
erikwright (departed)
7 years, 9 months ago (2013-03-01 19:40:00 UTC) #1
erikwright (departed)
7 years, 9 months ago (2013-03-01 19:41:03 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r185573.

Powered by Google App Engine
This is Rietveld 408576698