Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: chrome/browser/ui/search/search.cc

Issue 12387026: Expose getSearchTerms to tab_model for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed include errir Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/search.cc
diff --git a/chrome/browser/ui/search/search.cc b/chrome/browser/ui/search/search.cc
index e6d79bd0b396f29bd7fe61063768d7ef381625c2..48fc2aa3776e55667b17a4a805736cef658ac906 100644
--- a/chrome/browser/ui/search/search.cc
+++ b/chrome/browser/ui/search/search.cc
@@ -192,7 +192,7 @@ string16 GetSearchTerms(const content::WebContents* contents) {
Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
if (!IsQueryExtractionEnabled(profile))
return string16();
-
+#if !defined(OS_IOS) && !defined(OS_ANDROID)
Ted C 2013/03/01 02:50:21 Should we add a comment that IOS and Android do no
Yusuf 2013/03/01 18:58:20 Added comment. On 2013/03/01 02:50:21, Ted C wrot
// For security reasons, don't extract search terms if the page is not being
// rendered in the privileged Instant renderer process. This is to protect
// against a malicious page somehow scripting the search results page and
@@ -211,7 +211,7 @@ string16 GetSearchTerms(const content::WebContents* contents) {
if (!instant_service->IsInstantProcess(process_host->GetID()))
return string16();
-
+#endif
dhollowa 2013/03/01 00:35:51 nit: // !defined(OS_IOS) && !defined(OS_ANDROID)
Yusuf 2013/03/01 18:58:20 Done.
// Check to see if search terms have already been extracted.
const content::NavigationEntry* entry =
contents->GetController().GetVisibleEntry();

Powered by Google App Engine
This is Rietveld 408576698