collect minidump if it chrashes

tools/render_pdfs_main.cpp

Index: tools/render_pdfs_main.cpp
===================================================================
--- tools/render_pdfs_main.cpp	(revision 8016)
+++ tools/render_pdfs_main.cpp	(working copy)
@@ -16,6 +16,10 @@
 #include "PdfRenderer.h"
 #include "picture_utils.h"
 
+#ifdef SK_BUILD_FOR_WIN32

[borenet, 2013/03/07 20:22:39]

Shouldn't this be #ifdef SK_USE_CDB ?

[edisonn, 2013/03/07 20:43:42]

Done.

+#include "win_dbghelp.h"
+#endif
+
 /**
  * render_pdfs
  *
@@ -207,9 +211,8 @@
     }
 }
 
-int tool_main(int argc, char** argv);
-int tool_main(int argc, char** argv) {
-
+int tool_main_core(int argc, char** argv);
+int tool_main_core(int argc, char** argv) {
     SkAutoGraphics ag;
     SkTArray<SkString> inputs;
 
@@ -229,9 +232,27 @@
         SkDebugf("Failed to render %i PDFs.\n", failures);
         return 1;
     }
+
     return 0;
 }
 
+int tool_main(int argc, char** argv);
+int tool_main(int argc, char** argv) {
+#ifdef SK_USE_CDB
+    setUpDebuggingFromArgs(argv[0]);
+    __try {
+#endif
+      return tool_main_core(argc, argv);
+#ifdef SK_USE_CDB
+    }
+    __except(GenerateDumpAndPrintCallstack(GetExceptionInformation()))
+    {
+        return -1;
+    }
+#endif

[borenet, 2013/03/07 20:22:39]

Can we insert this stuff directly into tool_main without adding another layer? 
Or maybe add it into main()?

[edisonn, 2013/03/07 20:43:42]

If I do that, I get compile errors because of the try catch and variable
declarations.

d:\edisonn\skia-2\trunk\tools\render_pdfs_main.cpp(238): error C2220:
warning treated as error - no 'object' file generated
[D:\edisonn\skia-2\trunk\out\gyp\render_pdfs.vcxproj]
d:\edisonn\skia-2\trunk\tools\render_pdfs_main.cpp(238): warning C4509:
nonstandard extension used: 'tool_main' uses SEH and 'outputDir' has
destructor [D:\edisonn\skia-2\trunk\out\gyp\render_pdfs.vc
xproj]

On 2013/03/07 20:22:39, borenet wrote:

+    return 0;
+}
+
 #if !defined SK_BUILD_FOR_IOS
 int main(int argc, char * const argv[]) {
     return tool_main(argc, (char**) argv);