Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1651)

Unified Diff: tests/lib/async/future_test.dart

Issue 12387012: Fix mising rename in tests of Future.isCompleted. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: All of them Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/async/future_test.dart
diff --git a/tests/lib/async/future_test.dart b/tests/lib/async/future_test.dart
index 87e669e5d401488313fdecdfa26764342dd9ea6f..af4a5dd5139300186f1b93b9f2a75913fe460e49 100644
--- a/tests/lib/async/future_test.dart
+++ b/tests/lib/async/future_test.dart
@@ -53,10 +53,10 @@ testNeverComplete() {
testComplete() {
final completer = new Completer<int>();
final future = completer.future;
- Expect.isFalse(completer.completed);
+ Expect.isFalse(completer.isCompleted);
completer.complete(3);
- Expect.isTrue(completer.completed);
+ Expect.isTrue(completer.isCompleted);
future.then((v) => Expect.equals(3, v));
}
@@ -71,9 +71,9 @@ testCompleteWithSuccessHandlerBeforeComplete() {
future.then((int v) { value = v; });
Expect.isNull(value);
- Expect.isFalse(completer.completed);
+ Expect.isFalse(completer.isCompleted);
completer.complete(3);
- Expect.isTrue(completer.completed);
+ Expect.isTrue(completer.isCompleted);
Expect.equals(3, value);
}
@@ -141,9 +141,9 @@ testExceptionHandler() {
var ex2;
var done = future.catchError((e) { ex2 = e.error; });
- Expect.isFalse(completer.completed);
+ Expect.isFalse(completer.isCompleted);
completer.completeError(ex);
- Expect.isTrue(completer.completed);
+ Expect.isTrue(completer.isCompleted);
var port = new ReceivePort();
done.then((_) {
@@ -161,9 +161,9 @@ testExceptionHandlerReturnsTrue() {
future.catchError((e) { });
future.catchError((e) { reached = true; }, test: (e) => false)
.catchError((e) {});
- Expect.isFalse(completer.completed);
+ Expect.isFalse(completer.isCompleted);
completer.completeError(ex);
- Expect.isTrue(completer.completed);
+ Expect.isTrue(completer.isCompleted);
Expect.isFalse(reached);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698