Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1238693004: Stage --harmony-new-target (Closed)

Created:
5 years, 5 months ago by adamk
Modified:
5 years, 5 months ago
Reviewers:
rossberg
CC:
v8-dev, arv (Not doing code reviews)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage --harmony-new-target BUG=v8:3887 LOG=y Committed: https://crrev.com/5906ce337c2bdb6b52548590a297c8174d4595a0 Cr-Commit-Position: refs/heads/master@{#29714}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -1 line 0 comments Download
M test/test262-es6/test262-es6.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
From what I can tell new.target works everywhere (regular functions, arrow functions, derived class constructors, ...
5 years, 5 months ago (2015-07-15 21:23:39 UTC) #2
rossberg
lgtm
5 years, 5 months ago (2015-07-16 11:30:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238693004/20001
5 years, 5 months ago (2015-07-16 19:47:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-16 20:48:24 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 20:48:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5906ce337c2bdb6b52548590a297c8174d4595a0
Cr-Commit-Position: refs/heads/master@{#29714}

Powered by Google App Engine
This is Rietveld 408576698