chrome/browser/renderer_context_menu/render_view_context_menu.cc - Issue 1238683003: Unpunycode search keywords and short names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1238683003: Unpunycode search keywords and short names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Fix comments, naming, code style. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc

diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

index 9c16c7a9562720da0cd5e68a9a355559817aa95b..c5d6f328a7c8be921a5fc5db063e2e9040bc9720 100644

--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc

+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc

@@ -1794,7 +1794,9 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {

SearchEngineTabHelper::FromWebContents(source_web_contents_);

if (search_engine_tab_helper &&

search_engine_tab_helper->delegate()) {

- base::string16 keyword(TemplateURL::GenerateKeyword(params_.page_url));

+ base::string16 keyword(TemplateURL::GenerateKeyword(

+ params_.page_url,

+ GetProfile()->GetPrefs()->GetString(prefs::kAcceptLanguages)));

TemplateURLData data;

data.SetShortName(keyword);

data.SetKeyword(keyword);