Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: components/search_engines/search_terms_data.h

Issue 1238683003: Unpunycode search keywords and short names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr
Patch Set: Restrict IDN-decoding to keywords generated from URL; Use prefs::kAcceptLanguages for IDN-decoding Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/search_engines/search_terms_data.h
diff --git a/components/search_engines/search_terms_data.h b/components/search_engines/search_terms_data.h
index 64d0f124b16b8d3716a8ccfd7757835779dc3d78..e460eb0d3114ae09380e6513d4738aebe0d5888d 100644
--- a/components/search_engines/search_terms_data.h
+++ b/components/search_engines/search_terms_data.h
@@ -74,6 +74,11 @@ class SearchTermsData {
// GOOGLE_IMAGE_SEARCH_SOURCE.
virtual std::string GoogleImageSearchSource() const;
+ // Returns a string with languages understood by the user.
+ // Proper implementation requires access to profile preferences
Peter Kasting 2015/07/20 19:30:51 Nit: For this second sentence, just copy the wordi
alshabalin 2015/07/21 08:44:19 Done.
+ // and is only implemented in UIThreadSearchTermsData.
+ virtual std::string GetAcceptedLanguages() const;
+
private:
DISALLOW_COPY_AND_ASSIGN(SearchTermsData);
};

Powered by Google App Engine
This is Rietveld 408576698