chrome/browser/search_engines/ui_thread_search_terms_data.h - Issue 1238683003: Unpunycode search keywords and short names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/search_engines/ui_thread_search_terms_data.h

Issue 1238683003: Unpunycode search keywords and short names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkgr

Patch Set: Restrict IDN-decoding to keywords generated from URL; Use prefs::kAcceptLanguages for IDN-decoding Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/search_engines/ui_thread_search_terms_data.h

diff --git a/chrome/browser/search_engines/ui_thread_search_terms_data.h b/chrome/browser/search_engines/ui_thread_search_terms_data.h

index ad40f5e919a793ecc3f3b335acf311bb2fc351ca..634a18f69396b0b97f4c5fc36edc41ce5dafbd6e 100644

--- a/chrome/browser/search_engines/ui_thread_search_terms_data.h

+++ b/chrome/browser/search_engines/ui_thread_search_terms_data.h

@@ -33,6 +33,7 @@ class UIThreadSearchTermsData : public SearchTermsData {

int OmniboxStartMargin() const override;

std::string NTPIsThemedParam() const override;

std::string GoogleImageSearchSource() const override;

+ std::string GetAcceptedLanguages() const override;

Peter Kasting 2015/07/20 19:30:51 Call this GetAcceptLanguages(), not "accepted", be

alshabalin 2015/07/21 08:44:19 Done.

// Used by tests to override the value for the Google base URL. Passing the

// empty string cancels this override.