Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1238623003: Add missing DETECT_IMPORTANT_CONTENT value to ContentSetting enum in UMA histograms. (Closed)

Created:
5 years, 5 months ago by lgarron
Modified:
5 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
asvitkine+watch_chromium.org, chromium-reviews, jww
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing DETECT_IMPORTANT_CONTENT value to ContentSetting enum in UMA histograms. This was accidentally missed in https://chromium.googlesource.com/chromium/src/+/a23713b67ee741e5bb026d99e86b8c97cc9ab84d BUG= Committed: https://crrev.com/31f774df0083901a2023ffb69894eeef3add6f69 Cr-Commit-Position: refs/heads/master@{#339741}

Patch Set 1 #

Patch Set 2 : Add DEFAULT, too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
lgarron
5 years, 5 months ago (2015-07-14 21:07:44 UTC) #2
lgarron
On 2015/07/14 at 21:07:44, lgarron wrote: > https://goto.google.com/uma-histograms?histograms=ContentSettings.DefaultPluginsSetting also shows some edge cases where people ...
5 years, 5 months ago (2015-07-14 21:13:45 UTC) #3
Ilya Sherman
LGTM. No reason that I can think of not to add an entry for DEFAULT ...
5 years, 5 months ago (2015-07-16 01:53:11 UTC) #4
lgarron
Cool, I've added DEFAULT.
5 years, 5 months ago (2015-07-21 19:10:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238623003/20001
5 years, 5 months ago (2015-07-21 19:11:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 20:38:58 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:39:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31f774df0083901a2023ffb69894eeef3add6f69
Cr-Commit-Position: refs/heads/master@{#339741}

Powered by Google App Engine
This is Rietveld 408576698