ChromeOS: Appending boot times to symlink in /tmp is a security risk for developers.

chrome/browser/chromeos/boot_times_recorder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/boot_times_recorder.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
+#include "base/sys_info.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/threading/thread.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time/time.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
@@ skipping 40 matching lines @@
       }
     }
   }
   return std::string();
 }
 
 // Appends the given buffer into the file. Returns the number of bytes
 // written, or -1 on error.
 // TODO(satorux): Move this to file_util.
 int AppendFile(const base::FilePath& file_path, const char* data, int size) {
+  // Appending boot times to symlink in /tmp is a security risk for
+  // developers with chromeos=1 builds.
+  if (!base::SysInfo::IsRunningOnChromeOS() && base::IsLink(file_path))
+    return -1;
+
   FILE* file = base::OpenFile(file_path, "a");
   if (!file)
     return -1;
 
   const int num_bytes_written = fwrite(data, 1, size, file);
   base::CloseFile(file);
   return num_bytes_written;
 }
 
 }  // namespace
@@ skipping 423 matching lines @@
           GetRenderWidgetHost(&web_contents->GetController());
       render_widget_hosts_loading_.erase(render_widget_host);
       break;
     }
     default:
       break;
   }
 }
 
 }  // namespace chromeos