Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Issue 12386091: Simplify check_tls on ARM, now that llvm emits mapping symbols. (Closed)

Created:
7 years, 9 months ago by jvoung (off chromium)
Modified:
7 years, 9 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Simplify check_tls on ARM, now that llvm emits mapping symbols. Stop using -D plus some filters. Just -d it. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2818 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10941

Patch Set 1 #

Total comments: 2

Patch Set 2 : simplify_more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M src/untrusted/irt/check_tls.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/untrusted/irt/check_tls.py View 1 2 chunks +1 line, -8 lines 0 comments Download
M src/untrusted/irt/nacl.scons View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jvoung (off chromium)
7 years, 9 months ago (2013-03-04 22:59:09 UTC) #1
Roland McGrath
LGTM with cleanup below. https://codereview.chromium.org/12386091/diff/1/src/untrusted/irt/check_tls.py File src/untrusted/irt/check_tls.py (right): https://codereview.chromium.org/12386091/diff/1/src/untrusted/irt/check_tls.py#newcode46 src/untrusted/irt/check_tls.py:46: proc = subprocess.Popen(objdump_args, objdump_flags and ...
7 years, 9 months ago (2013-03-04 23:15:41 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/12386091/diff/1/src/untrusted/irt/check_tls.py File src/untrusted/irt/check_tls.py (right): https://codereview.chromium.org/12386091/diff/1/src/untrusted/irt/check_tls.py#newcode46 src/untrusted/irt/check_tls.py:46: proc = subprocess.Popen(objdump_args, On 2013/03/04 23:15:41, Roland McGrath wrote: ...
7 years, 9 months ago (2013-03-05 00:34:40 UTC) #3
Roland McGrath
lgtm
7 years, 9 months ago (2013-03-05 00:46:28 UTC) #4
jvoung (off chromium)
7 years, 9 months ago (2013-03-05 00:56:17 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r10941 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698