Issue 12386084: Wait for sweeper threads and finalize sweeping only if parallel/concurrent sweeping was in progress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12386084: Wait for sweeper threads and finalize sweeping only if parallel/concurrent sweeping was in progress. (Closed)

Created:
7 years, 9 months ago by Hannes Payer (out of office)

Modified:
7 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Wait for sweeper threads and finalize sweeping only if parallel/concurrent sweeping was in progress. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13810

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
	M	src/mark-compact.cc	View	1 2	2 chunks	+9 lines, -10 lines	0 comments	Download
	M	src/spaces.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM, with one nit. https://codereview.chromium.org/12386084/diff/2001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/12386084/diff/2001/src/mark-compact.cc#newcode910 src/mark-compact.cc:910: if (sweeping_pending_) { Better use ...

7 years, 9 months ago (2013-03-04 14:43:08 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/12386084/diff/2001/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/12386084/diff/2001/src/mark-compact.cc#newcode910 src/mark-compact.cc:910: if (sweeping_pending_) { On 2013/03/04 14:43:08, Michael Starzinger wrote: ...

7 years, 9 months ago (2013-03-04 14:56:11 UTC) #3

Hannes Payer (out of office)

7 years, 9 months ago (2013-03-04 14:56:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r13810 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12386084: Wait for sweeper threads and finalize sweeping only if parallel/concurrent sweeping was in progress. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages