Issue 12386080: Launch the action choice dialog for USB devices with an DCIM directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12386080: Launch the action choice dialog for USB devices with an DCIM directory. (Closed)

Created:
7 years, 9 months ago by mtomasz

Modified:
7 years, 9 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Launch the action choice dialog for USB devices with an DCIM directory. Before, we were launching it only for sd card. Now, any device with a DCIM directory will invoke the action choice dialog. TEST=Enter an usb stick with a DCIM folder. Also test an sd card with a DCIM folder. If DCIM exists then action choice should appear. Otherwise Files.app. BUG=179582 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185848

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	chrome/browser/chromeos/extensions/file_browser_event_router.cc	View		1 chunk	+6 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/12386080/1

7 years, 9 months ago (2013-03-04 06:02:48 UTC) #3

Message was sent while issue was closed.

Change committed as 185848

Expand Messages | Collapse Messages