Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Side by Side Diff: tools/bots/compiler.py

Issue 12386047: Quote all arguments when printing test.py command (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/bots/bot.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 2
3 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 3 # Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
4 # for details. All rights reserved. Use of this source code is governed by a 4 # for details. All rights reserved. Use of this source code is governed by a
5 # BSD-style license that can be found in the LICENSE file. 5 # BSD-style license that can be found in the LICENSE file.
6 6
7 """ 7 """
8 Dart2js buildbot steps 8 Dart2js buildbot steps
9 9
10 Runs tests for the dart2js compiler. 10 Runs tests for the dart2js compiler.
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 global IsFirstTestStepCall 142 global IsFirstTestStepCall
143 if IsFirstTestStepCall: 143 if IsFirstTestStepCall:
144 IsFirstTestStepCall = False 144 IsFirstTestStepCall = False
145 else: 145 else:
146 cmd.append('--append_logs') 146 cmd.append('--append_logs')
147 147
148 if flags: 148 if flags:
149 cmd.extend(flags) 149 cmd.extend(flags)
150 cmd.extend(targets) 150 cmd.extend(targets)
151 151
152 print 'running %s' % (' '.join(cmd)) 152 print 'Running: %s' % (' '.join(map(lambda arg: '"%s"' % arg, cmd)))
153 bot.RunProcess(cmd) 153 bot.RunProcess(cmd)
154 154
155 155
156 def TestCompiler(runtime, mode, system, flags, is_buildbot, test_set): 156 def TestCompiler(runtime, mode, system, flags, is_buildbot, test_set):
157 """ test the compiler. 157 """ test the compiler.
158 Args: 158 Args:
159 - runtime: either 'd8', 'jsshell', or one of the browsers, see GetBuildInfo 159 - runtime: either 'd8', 'jsshell', or one of the browsers, see GetBuildInfo
160 - mode: either 'debug' or 'release' 160 - mode: either 'debug' or 'release'
161 - system: either 'linux', 'mac', 'win7', or 'win8' 161 - system: either 'linux', 'mac', 'win7', or 'win8'
162 - flags: extra flags to pass to test.dart 162 - flags: extra flags to pass to test.dart
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 """ 321 """
322 with bot.BuildStep('Build SDK and d8'): 322 with bot.BuildStep('Build SDK and d8'):
323 args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode, 323 args = [sys.executable, './tools/build.py', '--mode=' + build_info.mode,
324 'dart2js_bot'] 324 'dart2js_bot']
325 print 'Build SDK and d8: %s' % (' '.join(args)) 325 print 'Build SDK and d8: %s' % (' '.join(args))
326 bot.RunProcess(args) 326 bot.RunProcess(args)
327 327
328 328
329 if __name__ == '__main__': 329 if __name__ == '__main__':
330 bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler) 330 bot.RunBot(GetBuildInfo, RunCompilerTests, build_step=BuildCompiler)
OLDNEW
« no previous file with comments | « tools/bots/bot.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698