Issue 12386021: Revert 144142

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12386021: Revert 144142 (Closed)

Created:
7 years, 9 months ago by karen

Modified:
7 years, 9 months ago

Reviewers:
haraken

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1425/

Visibility:
Public.

More Reviews

Description

Revert 144142 > [V8] Remove Event::dataTransferAttrGetterCustom() and Event::valueAttrSetterCustom() > https://bugs.webkit.org/show_bug.cgi?id=110666 > > Reviewed by Adam Barth. > > Event::dataTransferAttrGetterCustom() is not used > (i.e. the custom method is not registered to V8). > Event::valueAttrSetterCustom() is declared but not > implemented. We can remove them. > > No tests. No change in behavior. > > * bindings/scripts/CodeGeneratorV8.pm: > (GenerateHeaderCustomCall): > * bindings/v8/custom/V8EventCustom.cpp: > TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144314

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	Source/WebCore/bindings/v8/custom/V8EventCustom.cpp	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r144314.

Expand Messages | Collapse Messages