Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1112)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 12386019: Instant: Use only one hidden WebContents per profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index a0fd70eb1da4b15401c5781bc7f899009fa11cfd..e2dd59e7300246c654623c5459759c5f99226fac 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -20,6 +20,7 @@
#include "chrome/browser/extensions/script_bubble_controller.h"
#include "chrome/browser/extensions/tab_helper.h"
#include "chrome/browser/favicon/favicon_tab_helper.h"
+#include "chrome/browser/instant/instant_controller.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/search_engines/template_url.h"
#include "chrome/browser/search_engines/template_url_service.h"
@@ -1237,7 +1238,7 @@ bool LocationBarView::SkipDefaultKeyEventProcessing(const ui::KeyEvent& event) {
return true;
}
- // Tab while showing Instant commits instant immediately.
+ // Tab while showing Instant commits Instant immediately.
// Return true so that focus traversal isn't attempted. The edit ends
// up doing nothing in this case.
if (location_entry_->model()->AcceptCurrentInstantPreview())
@@ -1276,9 +1277,8 @@ bool LocationBarView::HasFocus() const {
}
void LocationBarView::OnBoundsChanged(const gfx::Rect& previous_bounds) {
- if (browser_ && browser_->instant_controller() && parent()) {
- browser_->instant_controller()->SetOmniboxBounds(bounds());
- }
+ if (browser_ && GetInstant() && parent())
+ GetInstant()->SetOmniboxBounds(bounds());
}
void LocationBarView::WriteDragDataForView(views::View* sender,
@@ -1330,11 +1330,6 @@ void LocationBarView::ShowFirstRunBubble() {
ShowFirstRunBubbleInternal();
}
-void LocationBarView::SetInstantSuggestion(
- const InstantSuggestion& suggestion) {
- location_entry_->model()->SetInstantSuggestion(suggestion);
-}
-
string16 LocationBarView::GetInputString() const {
return location_input_;
}

Powered by Google App Engine
This is Rietveld 408576698