chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm - Issue 12386019: Instant: Use only one hidden WebContents per profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

Issue 12386019: Instant: Use only one hidden WebContents per profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/browser.cc ('K') | « chrome/browser/ui/cocoa/tab_contents/instant_overlay_controller_mac.mm ('k') | chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller_browsertest.mm » ('j') | chrome/browser/ui/omnibox/location_bar.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

diff --git a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

index cfc9f5c86f02b5e3e13755dbfb937ca1e0b09a93..cf55258a76056dd8c2c7c6e7c8118bca2d4a8c23 100644

--- a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

+++ b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm

@@ -58,7 +58,7 @@

// overlay.

// TODO(sail): remove this when GWS gives chrome the height without the

// separator.

- if (drawDropShadow && heightUnits != INSTANT_SIZE_PERCENT)

+ if (drawDropShadow && heightUnits == INSTANT_SIZE_PIXELS)

--height;

if (overlayContents_ == overlay &&