chrome/browser/instant/instant_service_observer.h - Issue 12386019: Instant: Use only one hidden WebContents per profile.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/instant/instant_service_observer.h

Issue 12386019: Instant: Use only one hidden WebContents per profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_INSTANT_INSTANT_SERVICE_OBSERVER_H_

	6 #define CHROME_BROWSER_INSTANT_INSTANT_SERVICE_OBSERVER_H_

	7

	8 // This class defines the observer interface for InstantService.

	9 class InstantServiceObserver {
	samarth 2013/03/11 19:03:24 Did you leave out the default no-op implementation Did you leave out the default no-op implementation on purpose?
	10 public:

	11 // Indicates that either IsInstantEnabled() or IsInstantPrefEnabled() (as per

	12 // chrome/browser/ui/search/search.h) has changed in value.
	samarth 2013/03/11 19:03:24 nit: c/b/ui/search -> c/b/instant nit: c/b/ui/search -> c/b/instant
	13 virtual void InstantStatusChanged() = 0;

	14

	15 // Indicates that the user's custom theme has changed in some way.

	16 virtual void ThemeInfoChanged() = 0;

	17

	18 // Indicates that the Top Sites (Most Visited) info has changed in some way.

	19 virtual void MostVisitedItemsChanged() = 0;

	20

	21 protected:

	22 ~InstantServiceObserver() {}
	samarth 2013/03/12 21:31:21 Don't inline and make it virtual. Don't inline and make it virtual.
	23 };

	24

	25 #endif // CHROME_BROWSER_INSTANT_INSTANT_SERVICE_OBSERVER_H_

OLD	NEW