chrome/browser/instant/instant_service_observer.h - Issue 12386019: Instant: Use only one hidden WebContents per profile.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/instant/instant_service_observer.h

Issue 12386019: Instant: Use only one hidden WebContents per profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/instant/instant_service.cc ('K') | « chrome/browser/instant/instant_service_factory.cc ('k') | chrome/browser/instant/instant_tab.h » ('j') | chrome/browser/instant/instant_web_contents_container.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_INSTANT_INSTANT_SERVICE_OBSERVER_H_

	6 #define CHROME_BROWSER_INSTANT_INSTANT_SERVICE_OBSERVER_H_

	7

	8 // This class defines the observer interface for InstantService.

	9 class InstantServiceObserver {

	10 public:

	11 virtual void InstantStatusChanged() = 0;
	samarth 2013/03/01 17:59:53 Please document each of these. Please document each of these. sreeram 2013/03/07 18:18:46 Done. Show quoted text On 2013/03/01 17:59:53, samarth wrote: > Please document each of these. Done.
	12 virtual void ThemeInfoChanged() = 0;

	13 virtual void MostVisitedItemsChanged() = 0;

	14

	15 // For use in tests only.
	samarth 2013/03/01 17:59:53 I've seen an #ifdef UNIT_TEST in other places. Is I've seen an #ifdef UNIT_TEST in other places. Is there a #ifdef TEST or something that works for browser tests too that we can use here to enforce this? sreeram 2013/03/07 18:18:46 Done. Took this out. It was a bad idea to force re Show quoted text On 2013/03/01 17:59:53, samarth wrote: > I've seen an #ifdef UNIT_TEST in other places. Is there a #ifdef TEST or > something that works for browser tests too that we can use here to enforce this? Done. Took this out. It was a bad idea to force regular objects (InstantControllerImpl and InstantPreloader) to implement this meant-for-tests-only interface. Instead, we now use a notification. Aside: #define UNIT_TEST works for browser tests too, despite its name. However, I couldn't have used it here. The macro is set when compiling any test .cc file, but since instant_service.cc would've referenced this method, it wouldn't have worked. I.e., when instant_service.cc is compiled, the macro is false, so fine, all references to InstantSupportDecided() vanish. But now, you compile a *-test.cc file, and sure, it defines the macro, so you happily wait for InstantSupportDecided() to be called. Now, instant_service.cc is NOT going to be recompiled just to link your unit_test, so the call never arrives.
	16 virtual void InstantSupportDecided() = 0;

	17

	18 protected:

	19 ~InstantServiceObserver() {}

	20 };

	21

	22 #endif // CHROME_BROWSER_INSTANT_INSTANT_SERVICE_OBSERVER_H_

OLD	NEW