Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 12386016: Initial implementation of annotator library. (Closed)

Created:
7 years, 9 months ago by Mike Stip (use stip instead)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, xusydoc+watch_chromium.org, cmp-cc_chromium.org, ilevy+cc_chromium.org, kjellander+cc_chromium.org, lliabraa
Visibility:
Public.

Description

Initial implementation of annotator library. Consolidates annotator parsing and genreation code into a single file in scripts/common. Provides standardized way for slave scripts to use the annotator, and can be used as a bare-bones annotation out of the box. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=185960

Patch Set 1 #

Total comments: 10

Patch Set 2 : Rebase onto latest master. #

Patch Set 3 : Rebase to latest master. #

Patch Set 4 : Only use json, add always_run property. #

Total comments: 6

Patch Set 5 : Add unit tests, refactor step classes for protection. #

Total comments: 7

Patch Set 6 : Fix nits. #

Patch Set 7 : Fix flatten, add stdin support. #

Patch Set 8 : Add check for multiple logs. #

Patch Set 9 : Whitespace. #

Patch Set 10 : Rewrote testing to be python <2.7 compatible. #

Patch Set 11 : Missed one. #

Patch Set 12 : Rebase onto latest master. #

Patch Set 13 : More python 2.6 changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+731 lines, -35 lines) Patch
A scripts/common/annotator.py View 1 2 3 4 5 6 7 8 1 chunk +366 lines, -0 lines 0 comments Download
A scripts/common/unittests/annotator_test.py View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +334 lines, -0 lines 0 comments Download
M scripts/master/chromium_step.py View 4 chunks +31 lines, -35 lines 0 comments Download

Messages

Total messages: 28 (0 generated)
Mike Stip (use stip instead)
+cmp and lliabraa for FYI Nearly all callers should be using StructuredAnnotationStream, but I can't ...
7 years, 9 months ago (2013-02-28 07:55:30 UTC) #1
iannucci
This is sweeeeeeeet!! :D I'm thinking that the simplicity of the regular flavor will win ...
7 years, 9 months ago (2013-02-28 09:56:02 UTC) #2
Mike Stip (use stip instead)
updated https://codereview.chromium.org/12386016/diff/1/scripts/common/annotator.py File scripts/common/annotator.py (right): https://codereview.chromium.org/12386016/diff/1/scripts/common/annotator.py#newcode151 scripts/common/annotator.py:151: def step(self, name): On 2013/02/28 09:56:03, iannucci wrote: ...
7 years, 9 months ago (2013-02-28 20:35:22 UTC) #3
agable
I approve of this lots. So the default flow is going to be: master.cfg specifies ...
7 years, 9 months ago (2013-02-28 21:32:08 UTC) #4
cmp
Hey Mike, this is nice. But I see there are no tests being added in ...
7 years, 9 months ago (2013-02-28 23:09:28 UTC) #5
iannucci1
On 2013/02/28 23:09:28, cmp wrote: > Hey Mike, this is nice. But I see there ...
7 years, 9 months ago (2013-02-28 23:11:28 UTC) #6
Mike Stip (use stip instead)
On 2013/02/28 23:09:28, cmp wrote: > Hey Mike, this is nice. But I see there ...
7 years, 9 months ago (2013-02-28 23:12:22 UTC) #7
Mike Stip (use stip instead)
updated https://codereview.chromium.org/12386016/diff/3002/scripts/common/annotator.py File scripts/common/annotator.py (right): https://codereview.chromium.org/12386016/diff/3002/scripts/common/annotator.py#newcode114 scripts/common/annotator.py:114: class StructuredAnnotationStep(AdvancedAnnotationStream): On 2013/02/28 21:32:08, agable wrote: > ...
7 years, 9 months ago (2013-03-01 22:49:36 UTC) #8
agable
Just some nits. We'll add code to take input from annotated_run or another script that ...
7 years, 9 months ago (2013-03-02 00:49:56 UTC) #9
iannucci
This lgtm with some comments. I'm assuming as we roll this out we'll be diligent ...
7 years, 9 months ago (2013-03-02 01:49:14 UTC) #10
Mike Stip (use stip instead)
https://codereview.chromium.org/12386016/diff/8003/scripts/common/unittests/annotator_test.py File scripts/common/unittests/annotator_test.py (right): https://codereview.chromium.org/12386016/diff/8003/scripts/common/unittests/annotator_test.py#newcode80 scripts/common/unittests/annotator_test.py:80: perf='full_perf') On 2013/03/02 01:49:14, iannucci wrote: > Should there ...
7 years, 9 months ago (2013-03-02 02:13:45 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/12386016/9004
7 years, 9 months ago (2013-03-02 02:25:48 UTC) #12
commit-bot: I haz the power
Presubmit check for 12386016-9004 failed and returned exit status 1. INFO:root:Found 3 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 9 months ago (2013-03-02 02:30:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/12386016/9005
7 years, 9 months ago (2013-03-02 03:25:17 UTC) #14
commit-bot: I haz the power
Presubmit check for 12386016-9005 failed and returned exit status 1. INFO:root:Found 3 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 9 months ago (2013-03-02 03:29:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/12386016/11
7 years, 9 months ago (2013-03-02 03:32:34 UTC) #16
commit-bot: I haz the power
Presubmit check for 12386016-11 failed and returned exit status 1. INFO:root:Found 3 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 9 months ago (2013-03-02 03:36:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/12386016/11
7 years, 9 months ago (2013-03-02 03:41:02 UTC) #18
commit-bot: I haz the power
Presubmit check for 12386016-11 failed and returned exit status 1. INFO:root:Found 3 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 9 months ago (2013-03-02 03:45:26 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/12386016/11
7 years, 9 months ago (2013-03-02 18:11:25 UTC) #20
commit-bot: I haz the power
Presubmit check for 12386016-11 failed and returned exit status 1. INFO:root:Found 3 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 9 months ago (2013-03-02 18:15:44 UTC) #21
Isaac (away)
This is cool. Let me know if it is OK to import the StepCommands object ...
7 years, 9 months ago (2013-03-03 19:03:37 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/12386016/11
7 years, 9 months ago (2013-03-03 19:59:50 UTC) #23
commit-bot: I haz the power
Presubmit check for 12386016-11 failed and returned exit status 1. INFO:root:Found 3 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 9 months ago (2013-03-03 20:04:02 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/12386016/12005
7 years, 9 months ago (2013-03-04 19:29:38 UTC) #25
commit-bot: I haz the power
Presubmit check for 12386016-12005 failed and returned exit status 1. INFO:root:Found 3 file(s). INFO:PRESUBMIT:Running pylint ...
7 years, 9 months ago (2013-03-04 19:34:10 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xusydoc@chromium.org/12386016/2003
7 years, 9 months ago (2013-03-04 20:19:14 UTC) #27
commit-bot: I haz the power
7 years, 9 months ago (2013-03-04 20:23:27 UTC) #28
Message was sent while issue was closed.
Change committed as 185960

Powered by Google App Engine
This is Rietveld 408576698