Chromium Code Reviews

Unified Diff: src/harmony-typedarray.js

Issue 1238593003: Array.prototype.reverse should call [[HasProperty]] on elements before [[Get]] (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add packed implementation Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: src/harmony-typedarray.js
diff --git a/src/harmony-typedarray.js b/src/harmony-typedarray.js
index b9cc798ad2041b9aa9ab5a0a00d8096974f71952..8518b8571bb360dd267ee165f2fe910d8c700aff 100644
--- a/src/harmony-typedarray.js
+++ b/src/harmony-typedarray.js
@@ -44,13 +44,13 @@ var InnerArrayIndexOf;
var InnerArrayJoin;
var InnerArrayLastIndexOf;
var InnerArrayMap;
-var InnerArrayReverse;
var InnerArraySome;
var InnerArraySort;
var InnerArrayToLocaleString;
var IsNaN;
var MathMax;
var MathMin;
+var PackedArrayReverse;
utils.Import(function(from) {
ArrayFrom = from.ArrayFrom;
@@ -68,13 +68,13 @@ utils.Import(function(from) {
InnerArrayMap = from.InnerArrayMap;
InnerArrayReduce = from.InnerArrayReduce;
InnerArrayReduceRight = from.InnerArrayReduceRight;
- InnerArrayReverse = from.InnerArrayReverse;
InnerArraySome = from.InnerArraySome;
InnerArraySort = from.InnerArraySort;
InnerArrayToLocaleString = from.InnerArrayToLocaleString;
IsNaN = from.IsNaN;
MathMax = from.MathMax;
MathMin = from.MathMin;
+ PackedArrayReverse = from.PackedArrayReverse;
});
// -------------------------------------------------------------------
@@ -179,7 +179,7 @@ function TypedArrayReverse() {
var length = %_TypedArrayGetLength(this);
- return InnerArrayReverse(this, length);
+ return PackedArrayReverse(this, length);
}

Powered by Google App Engine