Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1238583002: sql: Cleanup to fix the header include guards. (Closed)

Created:
5 years, 5 months ago by tfarina
Modified:
5 years, 5 months ago
CC:
chromium-reviews, Scott Hess - ex-Googler
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sql: Cleanup to fix the header include guards. The header include guards should match the file path from root. These entries were found using a modified version of Eric's fix-include-guards.py script found attached in https://code.google.com/p/chromium/issues/detail?id=435361#c7. BUG=None TEST=sql_unittests R=erikwright@chromium.org Committed: https://crrev.com/fd5d2681c7b3b935ce292257cbaf6a5bbd12e93b Cr-Commit-Position: refs/heads/master@{#338703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M sql/init_status.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sql/sql_export.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
Erik, could you review this while Scott is OOO?
5 years, 5 months ago (2015-07-13 23:20:28 UTC) #2
erikwright (departed)
LGTM
5 years, 5 months ago (2015-07-14 14:50:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238583002/1
5 years, 5 months ago (2015-07-14 15:57:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-14 16:35:45 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 16:36:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fd5d2681c7b3b935ce292257cbaf6a5bbd12e93b
Cr-Commit-Position: refs/heads/master@{#338703}

Powered by Google App Engine
This is Rietveld 408576698