Add NewDSKeyFromEncoded convenience function.

Add NewDSKeyFromEncoded convenience function.

Also placate golint :).

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org
BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/8df693f3abd809a256651a96f0ce98279854b8c4

[Vadim Sh., 2015-07-17 01:16:35]

lgtm with nits

https://codereview.chromium.org/1238573004/diff/20001/go/src/infra/gae/libs/g...
File go/src/infra/gae/libs/gae/helper/generic_key.go (right):

https://codereview.chromium.org/1238573004/diff/20001/go/src/infra/gae/libs/g...
go/src/infra/gae/libs/gae/helper/generic_key.go:52: // NewDSKeyFromEncoded
decodes and returns a *GenericKey
a *GenericDSKey

https://codereview.chromium.org/1238573004/diff/20001/go/src/infra/gae/libs/g...
go/src/infra/gae/libs/gae/helper/generic_key.go:72: // Kind returns the
datastore kind of the entity
X is x of z.

that's how half of my godoc comments look like too :-/

(also you've forgot '.')

[iannucci, 2015-07-17 01:19:46]

https://chromiumcodereview.appspot.com/1238573004/diff/20001/go/src/infra/gae...
File go/src/infra/gae/libs/gae/helper/generic_key.go (right):

https://chromiumcodereview.appspot.com/1238573004/diff/20001/go/src/infra/gae...
go/src/infra/gae/libs/gae/helper/generic_key.go:52: // NewDSKeyFromEncoded
decodes and returns a *GenericKey
On 2015/07/17 01:16:35, Vadim Sh. wrote:
> a *GenericDSKey

Done.

https://chromiumcodereview.appspot.com/1238573004/diff/20001/go/src/infra/gae...
go/src/infra/gae/libs/gae/helper/generic_key.go:72: // Kind returns the
datastore kind of the entity
On 2015/07/17 01:16:35, Vadim Sh. wrote:
> X is x of z.
> 
> that's how half of my godoc comments look like too :-/

:/

> 
> (also you've forgot '.')

done.

[iannucci, 2015-07-17 01:20:42]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-07-17 01:20:43]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/1238573004/#ps60001
(title: "reparent off of dependency")

[commit-bot: I haz the power, 2015-07-17 01:20:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1238573004/60001

[commit-bot: I haz the power, 2015-07-17 01:24:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/infra/infra/+/8df693f3abd809a256651a96f0ce9...