Issue 1238573002: AnimatedType should hit |end|

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1238573002: AnimatedType should hit |end| (Closed)

Created:
5 years, 5 months ago by abarth-chromium

Modified:
5 years, 5 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

AnimatedType should hit |end| Some clients of AnimatedType watch for the |end| value to complete their work. This CL ensures that we actually hit the end when t == 1.0. Also, add a |distance| property to Offset. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/2e6d76137d9ce0464d345ab6c3ad148f31d52169

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -3 lines)			Patch
M	sky/engine/bindings/scripts/templates/dart_blink.template	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sky/engine/core/painting/Offset.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/animation/animation_performance.dart	View	1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 5 months ago (2015-07-13 23:09:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2e6d76137d9ce0464d345ab6c3ad148f31d52169 (presubmit successful).