Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1318)

Issue 123853002: Bump up timeout for session restore copy. (Closed)

Created:
6 years, 11 months ago by Anton
Modified:
6 years, 11 months ago
Reviewers:
aberent, bulach, tonyg, anton1
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Bump up timeout for session restore copy. Currently uses default timeout of 20 seconds. However at least 45 seconds are needed to copy the profile on Nakasi. Bumping the timeout to 60 seconds. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243293

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 8 (0 generated)
Anton
6 years, 11 months ago (2014-01-03 14:47:58 UTC) #1
aberent
lgtm
6 years, 11 months ago (2014-01-03 17:38:20 UTC) #2
tonyg
lgtm https://codereview.chromium.org/123853002/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py (right): https://codereview.chromium.org/123853002/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py#newcode87 tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:87: timeout_time = 60) nit: the style guide doesn't ...
6 years, 11 months ago (2014-01-05 20:00:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anton@chromium.org/123853002/1
6 years, 11 months ago (2014-01-06 13:15:33 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241825
6 years, 11 months ago (2014-01-06 15:44:03 UTC) #5
aberent
On 2014/01/06 15:44:03, I haz the power (commit-bot) wrote: > Retried try job too often ...
6 years, 11 months ago (2014-01-06 16:08:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/anton@chromium.org/123853002/1
6 years, 11 months ago (2014-01-07 11:43:45 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 14:32:50 UTC) #8
Message was sent while issue was closed.
Change committed as 243293

Powered by Google App Engine
This is Rietveld 408576698