Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: src/math.js

Issue 12385082: Make sure builtin functions don't rely on __proto__. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/messages.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 19 matching lines...) Expand all
30 // has the added benefit that the code in this file is isolated from 30 // has the added benefit that the code in this file is isolated from
31 // changes to these properties. 31 // changes to these properties.
32 var $floor = MathFloor; 32 var $floor = MathFloor;
33 var $abs = MathAbs; 33 var $abs = MathAbs;
34 34
35 // Instance class name can only be set on functions. That is the only 35 // Instance class name can only be set on functions. That is the only
36 // purpose for MathConstructor. 36 // purpose for MathConstructor.
37 function MathConstructor() {} 37 function MathConstructor() {}
38 %FunctionSetInstanceClassName(MathConstructor, 'Math'); 38 %FunctionSetInstanceClassName(MathConstructor, 'Math');
39 var $Math = new MathConstructor(); 39 var $Math = new MathConstructor();
40 $Math.__proto__ = $Object.prototype; 40 %SetPrototype($Math, $Object.prototype);
41 %SetProperty(global, "Math", $Math, DONT_ENUM); 41 %SetProperty(global, "Math", $Math, DONT_ENUM);
42 42
43 // ECMA 262 - 15.8.2.1 43 // ECMA 262 - 15.8.2.1
44 function MathAbs(x) { 44 function MathAbs(x) {
45 if (%_IsSmi(x)) return x >= 0 ? x : -x; 45 if (%_IsSmi(x)) return x >= 0 ? x : -x;
46 if (!IS_NUMBER(x)) x = NonNumberToNumber(x); 46 if (!IS_NUMBER(x)) x = NonNumberToNumber(x);
47 if (x === 0) return 0; // To handle -0. 47 if (x === 0) return 0; // To handle -0.
48 return x > 0 ? x : -x; 48 return x > 0 ? x : -x;
49 } 49 }
50 50
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
274 "sqrt", MathSqrt, 274 "sqrt", MathSqrt,
275 "tan", MathTan, 275 "tan", MathTan,
276 "atan2", MathAtan2, 276 "atan2", MathAtan2,
277 "pow", MathPow, 277 "pow", MathPow,
278 "max", MathMax, 278 "max", MathMax,
279 "min", MathMin 279 "min", MathMin
280 )); 280 ));
281 } 281 }
282 282
283 SetUpMath(); 283 SetUpMath();
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/messages.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698