webkit/media/webvideoframe_impl.h - Issue 12385073: Add interface implementations for WebVideoFrameImpl to give the exact video Format, textureId and t…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/media/webvideoframe_impl.h

Issue 12385073: Add interface implementations for WebVideoFrameImpl to give the exact video Format, textureId and t… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/media/webvideoframe_impl.h

diff --git a/webkit/media/webvideoframe_impl.h b/webkit/media/webvideoframe_impl.h

index 4680b5c8fe7929f4ed9e334f5bba755a74d95f13..11cb4f099a78dd6329520000384c2755f90b7ed6 100644

--- a/webkit/media/webvideoframe_impl.h

+++ b/webkit/media/webvideoframe_impl.h

@@ -19,7 +19,9 @@ class WebVideoFrameImpl : public WebKit::WebVideoFrame {

public:

WebVideoFrameImpl(scoped_refptr<media::VideoFrame> video_frame);

virtual ~WebVideoFrameImpl();

+ virtual WebKit::WebVideoFrame::Format format() const;

danakj 2013/03/04 15:57:50 Why can't you use the video_frame directly? This c

Ken Russell (switch to Gerrit) 2013/03/05 00:48:39 Is your suggestion to instead pass the WebVideoFra

+ virtual unsigned textureId() const;

+ virtual unsigned textureTarget() const;

scoped_refptr<media::VideoFrame> video_frame;

private:

« no previous file with comments | « no previous file | webkit/media/webvideoframe_impl.cc » ('j') | no next file with comments »