Introduce 'connecting' field to bluetooth device info for system tray

chrome/browser/chromeos/system/ash_system_tray_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/system/ash_system_tray_delegate.h"
 
 #include <algorithm>
 
 #include "ash/ash_switches.h"
 #include "ash/shell.h"
@@ skipping 485 matching lines @@
   virtual void GetAvailableBluetoothDevices(
       ash::BluetoothDeviceList* list) OVERRIDE {
     device::BluetoothAdapter::DeviceList devices =
         bluetooth_adapter_->GetDevices();
     for (size_t i = 0; i < devices.size(); ++i) {
       device::BluetoothDevice* device = devices[i];
       ash::BluetoothDeviceInfo info;
       info.address = device->address();
       info.display_name = device->GetName();
       info.connected = device->IsConnected();
+      info.connecting = device->IsConnecting();
       info.paired = device->IsPaired();
       info.visible = device->IsVisible();
       list->push_back(info);
     }
   }
 
   virtual void BluetoothStartDiscovering() OVERRIDE {
     bluetooth_adapter_->StartDiscovering(
         base::Bind(&base::DoNothing),
         base::Bind(&BluetoothSetDiscoveringError));
   }
 
   virtual void BluetoothStopDiscovering() OVERRIDE {
     bluetooth_adapter_->StopDiscovering(
         base::Bind(&base::DoNothing),
         base::Bind(&BluetoothSetDiscoveringError));
   }
 
   virtual void ToggleBluetoothConnection(const std::string& address) OVERRIDE {
     device::BluetoothDevice* device = bluetooth_adapter_->GetDevice(address);
     if (!device)
       return;
-    if (device->IsConnected()) {
+    if (device->IsConnected() || device->IsConnecting()) {

[jennyz, 2013/03/02 01:12:16]

If the bluetooth is connecting, it could be one of the two cases: if this is
already paired, it is connecting to the device; if this is not paired, it is
pairing with the device. For the pairing process, we probably should call
Disconnect. deymo should knows this better.

[deymo, 2013/03/02 02:31:13]

If IsConnecting is true, means that a connection is going on. This can include
the pairing process or not, but in any case, the connection will try to connect
the applications also (so, try to reach the connected=true state). So if the
device is connecting and the user clicks on that device, you may want to
do...hmm.. nothing? There's no other option more than just wait till the
connection finishes.

[Jun Mukai, 2013/04/09 03:15:08]

moved the conditions. now it attempts to connect.

       device->Disconnect(
           base::Bind(&base::DoNothing),
           base::Bind(&BluetoothDeviceDisconnectError));
     } else if (device->IsPaired()) {
       device->Connect(
           NULL,
           base::Bind(&base::DoNothing),
           base::Bind(&BluetoothDeviceConnectError));
     } else {  // Show paring dialog for the unpaired device.
       BluetoothPairingDialog* dialog =
@@ skipping 925 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(SystemTrayDelegate);
 };
 
 }  // namespace
 
 ash::SystemTrayDelegate* CreateSystemTrayDelegate() {
   return new chromeos::SystemTrayDelegate();
 }
 
 }  // namespace chromeos