Issue 12385050: A debug code assert needed to be behind the new optimize_constructed_arrays flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12385050: A debug code assert needed to be behind the new optimize_constructed_arrays flag. (Closed)

Created:
7 years, 9 months ago by mvstanton

Modified:
7 years, 9 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

A debug code assert needed to be behind the new optimize_constructed_arrays flag. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13791

Created: 7 years, 9 months ago

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -34 lines)
M	src/arm/builtins-arm.cc	View	1 chunk	+14 lines, -12 lines	0 comments
M	src/ia32/builtins-ia32.cc	View	1 chunk	+13 lines, -11 lines	0 comments
M	src/x64/builtins-x64.cc	View	1 chunk	+13 lines, -11 lines	0 comments

Total messages: 2 (0 generated)

mvstanton

Hi Michael, The bug is that we can only expect a property cell in EBX ...

7 years, 9 months ago (2013-03-01 16:57:56 UTC) #1

LGTM.