Add HasPublicKey to crx_id.

Add HasPublicKey to crx_id.

* Rename from_test_path to from_file_path.
* Add HasPublicKey test to unit test
* CRX_ID_DIR should use abspath, and it doesn't need to be a global.
* Replace BASE_DIR and UNPACKED_TEST_DIR with unpacked_test_manifest_path
* Split file_path based tests (testFromFilePath) off from testUnpackedHashAppId since they are not related.


BUG=177372
TEST=manual
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185567

[achuithb, 2013-03-01 02:26:13]

Jan: Can you please take a look?

[achuithb, 2013-03-01 02:30:21]

On 2013/03/01 02:26:13, achuith.bhandarkar wrote:
> Jan: Can you please take a look?

I need it for this CL:
https://codereview.chromium.org/12379034/

[jvoung (off chromium), 2013-03-01 03:17:22]

lgtm

https://codereview.chromium.org/12385037/diff/5001/tools/crx_id/crx_id_unitte...
File tools/crx_id/crx_id_unittest.py (right):

https://codereview.chromium.org/12385037/diff/5001/tools/crx_id/crx_id_unitte...
tools/crx_id/crx_id_unittest.py:56: os.path.join(temp_unpacked_crx,
Perhaps you can test your new method against the temp_unpacked_crx directory,
since it should contain a manifest that contains a key.

[achuithb, 2013-03-01 09:05:01]

PTAL. I've re-arranged some stuff in the unit test as well.

https://codereview.chromium.org/12385037/diff/5001/tools/crx_id/crx_id_unitte...
File tools/crx_id/crx_id_unittest.py (right):

https://codereview.chromium.org/12385037/diff/5001/tools/crx_id/crx_id_unitte...
tools/crx_id/crx_id_unittest.py:56: os.path.join(temp_unpacked_crx,
On 2013/03/01 03:17:22, jvoung (cr) wrote:
> Perhaps you can test your new method against the temp_unpacked_crx directory,
> since it should contain a manifest that contains a key.

Done.

[achuithb, 2013-03-01 09:08:30]

I've updated the description with my changes to the unit tests. Please let me
know what you think.

[jvoung (off chromium), 2013-03-01 15:48:19]

LGTM, thanks!

[achuithb, 2013-03-01 19:10:56]

On 2013/03/01 15:48:19, jvoung (cr) wrote:
> LGTM, thanks!

Thank you!

[commit-bot: I haz the power, 2013-03-01 19:13:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/achuith@chromium.org/12385037/5

[achuithb, 2013-03-01 19:32:12]

Committed patchset #5 manually as r185567 (presubmit successful).