src/ia32/macro-assembler-ia32.cc - Issue 12385014: Hydrogen stubs for array constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/macro-assembler-ia32.cc

Issue 12385014: Hydrogen stubs for array constructors (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: More efficient code when number of arguments is known Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/macro-assembler-ia32.cc

diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc

index 3228e8370e1ea9848ddbe0885462234784e885ce..46f75b5a9be412a440a97058ef5c91c3fbd88712 100644

--- a/src/ia32/macro-assembler-ia32.cc

+++ b/src/ia32/macro-assembler-ia32.cc

@@ -2531,10 +2531,13 @@ void MacroAssembler::VerifyX87StackDepth(uint32_t depth) {

and_(eax, kTopMask);

shr(eax, 11);

cmp(eax, Immediate(tos));

- Label all_ok;

- j(equal, &all_ok);

+ // These lines if you want to break right away

+ // Label all_ok;

+ // j(equal, &all_ok);

+ // int3();

+ // The check line otherwise

Check(equal, "Unexpected FPU stack depth after instruction");

- bind(&all_ok);

+ // bind(&all_ok);

fnclex();

pop(eax);

}