Hydrogen stubs for array constructors

src/builtins.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 182 matching lines @@
   return isolate->heap()->undefined_value();
 }
 
 
 #define CONVERT_ARG_STUB_CALLER_ARGS(name)                           \
   Arguments* name = reinterpret_cast<Arguments*>(args[0]);
 
 
 RUNTIME_FUNCTION(MaybeObject*, ArrayConstructor_StubFailure) {
   CONVERT_ARG_STUB_CALLER_ARGS(caller_args);
-  // ASSERT(args.length() == 3);
-  Handle<JSFunction> function = args.at<JSFunction>(1);
-  Handle<Object> type_info = args.at<Object>(2);
+  // ASSERT(args.length() == 2);

[Hannes Payer (out of office), 2013/04/18 11:14:39]

Is this ASSERT still needed?

[mvstanton, 2013/04/18 13:39:26]

It's good to have, and I should enable the darn thing. Enabled.

+  Handle<Object> type_info = args.at<Object>(1);
 
   JSArray* array = NULL;
   bool holey = false;
   if (caller_args->length() == 1 && (*caller_args)[0]->IsSmi()) {
     int value = Smi::cast((*caller_args)[0])->value();
     holey = (value > 0 && value < JSObject::kInitialMaxFastElementArray);
   }
 
   MaybeObject* maybe_array;
   if (*type_info != isolate->heap()->undefined_value()) {
@@ skipping 11 matching lines @@
       if (mode == TRACK_ALLOCATION_SITE) {
         maybe_array = isolate->heap()->AllocateEmptyJSArrayWithAllocationSite(
             to_kind, type_info);
       } else {
         maybe_array = isolate->heap()->AllocateEmptyJSArray(to_kind);
       }
       if (!maybe_array->To(&array)) return maybe_array;
     }
   }
 
-  ASSERT(function->has_initial_map());
-  ElementsKind kind = function->initial_map()->elements_kind();
+  ElementsKind kind = GetInitialFastElementsKind();
   if (holey) {
     kind = GetHoleyElementsKind(kind);
   }
 
   if (array == NULL) {
     maybe_array = isolate->heap()->AllocateEmptyJSArray(kind);
     if (!maybe_array->To(&array)) return maybe_array;
   }
 
   maybe_array = ArrayConstructInitializeElements(array, caller_args);
@@ skipping 1626 matching lines @@
   return Handle<Code>(code_address);                        \
 }
 BUILTIN_LIST_C(DEFINE_BUILTIN_ACCESSOR_C)
 BUILTIN_LIST_A(DEFINE_BUILTIN_ACCESSOR_A)
 BUILTIN_LIST_DEBUG_A(DEFINE_BUILTIN_ACCESSOR_A)
 #undef DEFINE_BUILTIN_ACCESSOR_C
 #undef DEFINE_BUILTIN_ACCESSOR_A
 
 
 } }  // namespace v8::internal