Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1238463002: Minor cleanup IC keyed access handling. (Closed)

Created:
5 years, 5 months ago by Toon Verwaest
Modified:
5 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Minor cleanup IC keyed access handling. BUG= Committed: https://crrev.com/0fd9a0a3bf65ece1e74a16747443960b27dbb514 Cr-Commit-Position: refs/heads/master@{#29614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -46 lines) Patch
M src/ic/ic.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 3 chunks +15 lines, -17 lines 0 comments Download
M src/objects.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -19 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
ptal
5 years, 5 months ago (2015-07-13 10:40:27 UTC) #2
Igor Sheludko
lgtm
5 years, 5 months ago (2015-07-13 13:54:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238463002/1
5 years, 5 months ago (2015-07-13 14:03:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-13 14:41:42 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 14:41:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fd9a0a3bf65ece1e74a16747443960b27dbb514
Cr-Commit-Position: refs/heads/master@{#29614}

Powered by Google App Engine
This is Rietveld 408576698