content/browser/indexed_db/indexed_db_backing_store.cc - Issue 1238393003: [IndexedDB] Adding traces, perf tests

Unified Diff: content/browser/indexed_db/indexed_db_backing_store.cc

Issue 1238393003: [IndexedDB] Adding traces, perf tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/indexeddb/perf_test.js ('k') | content/browser/indexed_db/indexed_db_database.cc » ('j') | content/browser/indexed_db/indexed_db_transaction.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_backing_store.cc

diff --git a/content/browser/indexed_db/indexed_db_backing_store.cc b/content/browser/indexed_db/indexed_db_backing_store.cc

index eff43e0f0d32f14672f786f82b3667a2de8a1286..084ddadeff6f85ab39d8e454e9ac58108f4edcee 100644

--- a/content/browser/indexed_db/indexed_db_backing_store.cc

+++ b/content/browser/indexed_db/indexed_db_backing_store.cc

@@ -666,6 +666,7 @@ static leveldb::Status MergeDatabaseIntoBlobJournal(

LevelDBDirectTransaction* transaction,

const std::string& key,

int64 database_id) {

+ IDB_TRACE("IndexedDBBackingStore::MergeDatabaseIntoBlobJournal");

BlobJournalType journal;

leveldb::Status s = GetBlobJournal(key, transaction, &journal);

if (!s.ok())

@@ -1474,11 +1475,14 @@ leveldb::Status IndexedDBBackingStore::DeleteDatabase(

metadata.id, DatabaseMetaDataKey::ORIGIN_NAME);

const std::string stop_key = DatabaseMetaDataKey::Encode(

metadata.id + 1, DatabaseMetaDataKey::ORIGIN_NAME);

- scoped_ptr<LevelDBIterator> it = db_->CreateIterator();

- for (s = it->Seek(start_key);

- s.ok() && it->IsValid() && CompareKeys(it->Key(), stop_key) < 0;

- s = it->Next())

- transaction->Remove(it->Key());

+ {

+ IDB_TRACE("IndexedDBBackingStore::DeleteDatabase::DeleteEntries");

cmumford 2015/08/03 17:31:33 Nit: I believe that all other traces we use <class

dmurph 2015/08/05 15:30:32 Sure, that sounds good. I'll switch to the '.' ver

+ scoped_ptr<LevelDBIterator> it = db_->CreateIterator();

+ for (s = it->Seek(start_key);

+ s.ok() && it->IsValid() && CompareKeys(it->Key(), stop_key) < 0;

+ s = it->Next())

+ transaction->Remove(it->Key());

+ }

if (!s.ok()) {

INTERNAL_WRITE_ERROR_UNTESTED(DELETE_DATABASE);

return s;

@@ -2712,6 +2716,7 @@ leveldb::Status IndexedDBBackingStore::CleanUpBlobJournalEntries(

leveldb::Status IndexedDBBackingStore::CleanUpBlobJournal(

const std::string& level_db_key) const {

+ IDB_TRACE("IndexedDBBackingStore::CleanUpBlobJournal");

DCHECK(!committing_transaction_count_);

leveldb::Status s;

scoped_refptr<LevelDBTransaction> journal_transaction =