[IndexedDB] Adding traces, perf tests

tools/perf/benchmarks/indexeddb_perf.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Chromium's IndexedDB performance test. These test:
 
 Databases:
   create/delete
 Keys:
   create/delete
 Indexes:
   create/delete
 Data access:
   Random read/write
   Read cache
 Cursors:
   Read & random writes
   Walking multiple
   Seeking.
 """
 
 import json
-import os
 
 from core import perf_benchmark
 
-from telemetry.core import util
-from telemetry import page as page_module
 from telemetry.page import page_test
-from telemetry import story
 from telemetry.value import scalar
 
 from metrics import memory
 from metrics import power
 
+import page_sets
+
+from telemetry.timeline import tracing_category_filter
+from telemetry.web_perf import timeline_based_measurement
+
+
+IDB_CATEGORY = 'IndexedDB'
+TIMELINE_REQUIRED_CATEGORY = 'blink.console'
 
 class _IndexedDbMeasurement(page_test.PageTest):
   def __init__(self):
     super(_IndexedDbMeasurement, self).__init__()
     self._memory_metric = None
     self._power_metric = None
 
   def WillStartBrowser(self, platform):
     """Initialize metrics once right before the browser has been launched."""
     self._power_metric = power.PowerMetric(platform)
 
   def DidStartBrowser(self, browser):
     """Initialize metrics once right after the browser has been launched."""
     self._memory_metric = memory.MemoryMetric(browser)
 
   def DidNavigateToPage(self, page, tab):
     self._memory_metric.Start(page, tab)
     self._power_metric.Start(page, tab)
 
   def ValidateAndMeasurePage(self, page, tab, results):
     tab.WaitForDocumentReadyStateToBeComplete()
-    tab.WaitForJavaScriptExpression(
-        'window.document.cookie.indexOf("__done=1") >= 0', 600)
+    tab.WaitForJavaScriptExpression('window.done == true', 600)

[cmumford, 2015/08/03 17:31:33]

Nit: why not just 'window.done'?

[dmurph, 2015/08/05 15:30:32]

ah, true.

 
     self._power_metric.Stop(page, tab)
     self._memory_metric.Stop(page, tab)
 
     self._memory_metric.AddResults(tab, results)
     self._power_metric.AddResults(tab, results)
 
     js_get_results = "JSON.stringify(automation.getResults());"
     result_dict = json.loads(tab.EvaluateJavaScript(js_get_results))
     total = 0.0
     for key in result_dict:
       if key == 'OverallTestDuration':
         continue
       msec = float(result_dict[key])
       results.AddValue(scalar.ScalarValue(
           results.current_page, key, 'ms', msec, important=False))
 
       total += msec
     results.AddValue(scalar.ScalarValue(
         results.current_page, 'Total Perf', 'ms', total))
 
 
   def CustomizeBrowserOptions(self, options):
     memory.MemoryMetric.CustomizeBrowserOptions(options)
     power.PowerMetric.CustomizeBrowserOptions(options)
 
+
 class IndexedDb(perf_benchmark.PerfBenchmark):
   """Chromium's IndexedDB Performance tests."""
   test = _IndexedDbMeasurement
+  page_set = page_sets.IndexedDBEndurePageSet
 
   @classmethod
   def Name(cls):
     return 'indexeddb_perf'
 
-  def CreateStorySet(self, options):
-    indexeddb_dir = os.path.join(util.GetChromiumSrcDir(), 'chrome', 'test',
-                                 'data', 'indexeddb')
-    ps = story.StorySet(base_dir=indexeddb_dir)
-    ps.AddStory(page_module.Page('file://perf_test.html', ps, ps.base_dir))
-    return ps
+
+class IndexedDbTracing(perf_benchmark.PerfBenchmark):
+  """IndexedDB Performance tests that use tracing."""
+  page_set = page_sets.IndexedDBEndurePageSet
+
+  def CreateTimelineBasedMeasurementOptions(self):
+    cat_filter = tracing_category_filter.CreateMinimalOverheadFilter()
+    cat_filter.AddIncludedCategory(IDB_CATEGORY)
+    cat_filter.AddIncludedCategory(TIMELINE_REQUIRED_CATEGORY)
+
+    return timeline_based_measurement.Options(
+        overhead_level=cat_filter)
+
+  @classmethod
+  def Name(cls):
+    return 'storage.indexeddb'
+
+  @classmethod
+  def ValueCanBeAddedPredicate(cls, value, is_first_result):
+    if 'idb' not in value.name:

[cmumford, 2015/08/03 17:31:34]

This logic makes me think way too much. Why not just:

return 'idb' in value.name

[dmurph, 2015/08/05 15:30:32]

Done.

+      return False
+    return True