Issue 1238353002: Roll clang 241602:242792

Issue 1238353002: Roll clang 241602:242792 (Closed)

Created:
5 years, 5 months ago by Nico

Modified:
5 years, 5 months ago

Reviewers:
hans

CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Roll clang 241602:242792 A fairly small roll, not much in it. * Bump version from 3.7.0 to 3.8.0 * sdefresne's change to the plugin to emit warnings in files that have Developer in the path (system headers should still not warn by virtue of being system headers; clang doesn't emit warnings in system headers) BUG=510886 Committed: https://crrev.com/2034d2be49ef144451d8b1a81d045360b4a7d8aa Cr-Commit-Position: refs/heads/master@{#339838}

Patch Set 1 #

Patch Set 2 : 242417 #

Patch Set 3 : fixme #

Patch Set 4 : 242792 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	tools/clang/scripts/update.py	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	tools/clang/scripts/update.sh	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 16 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Nico

(i just removed the 2nd bullet from the cl description; looks like that change didn't ...

5 years, 5 months ago (2015-07-20 19:11:40 UTC) #3

Nico

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF obj/third_party/opus/src/silk/fixed/opus.encode_frame_FIX.o.d -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=242417-1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 ...

5 years, 5 months ago (2015-07-20 20:10:17 UTC) #5

FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF
obj/third_party/opus/src/silk/fixed/opus.encode_frame_FIX.o.d
-DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=242417-1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
-DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DDONT_EMBED_BUILD_METADATA
-DDCHECK_ALWAYS_ON=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DOPUS_BUILD -DOPUS_EXPORT=
-DHAVE_LRINT -DHAVE_LRINTF -DVAR_ARRAYS -DFIXED_POINT -DOPUS_ARM_ASM
-DOPUS_ARM_INLINE_ASM -DOPUS_ARM_INLINE_EDSP -DOPUS_ARM_MAY_HAVE_EDSP
-DOPUS_ARM_MAY_HAVE_MEDIA -DOPUS_ARM_MAY_HAVE_NEON -DOPUS_HAVE_RTCD
-DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen
-I../../third_party/opus/src/celt -I../../third_party/opus/src/include
-I../../third_party/opus/src/silk -I../../third_party/opus/src/silk/fixed
-fstack-protector --param=ssp-buffer-size=4 -Werror -pthread
-fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers
-fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load
-Xclang
/b/build/slave/linux_arm/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-overloaded-virtual -Wno-unused-variable
-Wno-#pragma-messages -O3 -Wno-format -Wno-unused-result -target
arm-linux-gnueabihf -march=armv7-a -no-integrated-as -mtune=generic-armv7-a
-mfpu=neon -mfloat-abi=hard -mthumb
--sysroot=/b/build/slave/linux_arm/build/src/build/linux/debian_wheezy_arm-sysroot
-O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables   -c
../../third_party/opus/src/silk/fixed/encode_frame_FIX.c -o
obj/third_party/opus/src/silk/fixed/opus.encode_frame_FIX.o
/tmp/encode_frame_FIX-637210.s: Assembler messages:
/tmp/encode_frame_FIX-637210.s:917: Error: r13 not allowed here -- `ldrd
sp,r0,[r6,#12]'
clang:error: assembler command failed with exit code 1 (use -v to see
invocation)
FAILED: /b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang -MMD -MF
obj/third_party/opus/src/silk/fixed/opus.find_LPC_FIX.o.d
-DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=242417-1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
-DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DDONT_EMBED_BUILD_METADATA
-DDCHECK_ALWAYS_ON=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DOPUS_BUILD -DOPUS_EXPORT=
-DHAVE_LRINT -DHAVE_LRINTF -DVAR_ARRAYS -DFIXED_POINT -DOPUS_ARM_ASM
-DOPUS_ARM_INLINE_ASM -DOPUS_ARM_INLINE_EDSP -DOPUS_ARM_MAY_HAVE_EDSP
-DOPUS_ARM_MAY_HAVE_MEDIA -DOPUS_ARM_MAY_HAVE_NEON -DOPUS_HAVE_RTCD
-DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DNDEBUG
-DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen
-I../../third_party/opus/src/celt -I../../third_party/opus/src/include
-I../../third_party/opus/src/silk -I../../third_party/opus/src/silk/fixed
-fstack-protector --param=ssp-buffer-size=4 -Werror -pthread
-fno-strict-aliasing -Wno-unused-parameter -Wno-missing-field-initializers
-fvisibility=hidden -pipe -fPIC -Wno-reserved-user-defined-literal -Xclang -load
-Xclang
/b/build/slave/linux_arm/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-templates -fcolor-diagnostics
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-overloaded-virtual -Wno-unused-variable
-Wno-#pragma-messages -O3 -Wno-format -Wno-unused-result -target
arm-linux-gnueabihf -march=armv7-a -no-integrated-as -mtune=generic-armv7-a
-mfpu=neon -mfloat-abi=hard -mthumb
--sysroot=/b/build/slave/linux_arm/build/src/build/linux/debian_wheezy_arm-sysroot
-O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables   -c
../../third_party/opus/src/silk/fixed/find_LPC_FIX.c -o
obj/third_party/opus/src/silk/fixed/opus.find_LPC_FIX.o
/tmp/find_LPC_FIX-4b85e7.s: Assembler messages:
/tmp/find_LPC_FIX-4b85e7.s:245: Error: r13 not allowed here -- `ldrd
sp,r1,[r6,#4]'
clang:error: assembler command failed with exit code 1 (use -v to see
invocation)
ninja: build stopped: subcommand failed.


:-( :-( :-(

I guess we don't have a bot targeting armv7-a on the tot waterfall?

hans

On 2015/07/20 20:10:17, Nico wrote: > :-( :-( :-( > > I guess we don't ...

5 years, 5 months ago (2015-07-20 20:13:57 UTC) #6

Nico

On 2015/07/20 20:13:57, hans wrote: > On 2015/07/20 20:10:17, Nico wrote: > > :-( :-( ...

5 years, 5 months ago (2015-07-20 20:16:45 UTC) #7

hans

On 2015/07/21 21:17:56, Nico wrote: > Trying this again. Did you receive the push email ...

5 years, 5 months ago (2015-07-21 21:20:24 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238353002/60001

5 years, 5 months ago (2015-07-22 05:13:05 UTC) #14

commit-bot: I haz the power

5 years, 5 months ago (2015-07-22 05:18:26 UTC) #16

Message was sent while issue was closed.

Patchset 4 (id:??) landed as
https://crrev.com/2034d2be49ef144451d8b1a81d045360b4a7d8aa
Cr-Commit-Position: refs/heads/master@{#339838}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages