Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 1238313003: Remove an expectation for an exception from CrossOriginXHRBackgroundPage test (Closed)

Created:
5 years, 5 months ago by tyoshino (SeeGerritForStatus)
Modified:
5 years, 5 months ago
Reviewers:
yhirano
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove an expectation for an exception from CrossOriginXHRBackgroundPage test XHR stops throwing NetworkError exceptions from https://codereview.chromium.org/1060113004/ Prepare for it by removing chrome.test.fail() call but keeping the expectation set for the error event. After landing the Blink side patch, remove the try-catch. BUG=479484 R=yhirano Committed: https://crrev.com/5ef30a1f6ebdf7a7ffc1e48eb843814987866246 Cr-Commit-Position: refs/heads/master@{#339828}

Patch Set 1 #

Patch Set 2 : Keep try-catch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
tyoshino (SeeGerritForStatus)
5 years, 5 months ago (2015-07-21 06:41:59 UTC) #2
yhirano
lgtm
5 years, 5 months ago (2015-07-21 06:47:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238313003/1
5 years, 5 months ago (2015-07-21 07:41:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/30126)
5 years, 5 months ago (2015-07-21 08:19:13 UTC) #7
tyoshino (SeeGerritForStatus)
yhirano: PTAL. We need two steps. Changed this CL to just remove the chrome.test.fail() call.
5 years, 5 months ago (2015-07-21 08:35:16 UTC) #8
yhirano
lgtm
5 years, 5 months ago (2015-07-21 08:36:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238313003/20001
5 years, 5 months ago (2015-07-21 08:36:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/82552)
5 years, 5 months ago (2015-07-21 09:58:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238313003/20001
5 years, 5 months ago (2015-07-22 02:27:43 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 03:12:39 UTC) #16
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 03:13:11 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5ef30a1f6ebdf7a7ffc1e48eb843814987866246
Cr-Commit-Position: refs/heads/master@{#339828}

Powered by Google App Engine
This is Rietveld 408576698