Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 12383076: MIPS: Fix materialization of arguments objects with unknown values. (Closed)

Created:
7 years, 9 months ago by palfia
Modified:
7 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix materialization of arguments objects with unknown values. Port r13763 (6b32e7d6) Original commit message: This fixes the deoptimizer to materialize arguments objects of correct length even in cases where the actual argument values are unknown and were optimized away by Crankshaft. This can happen if only the length property or the identity of an arguments object is used. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -20 lines) Patch
M src/mips/lithium-codegen-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 7 chunks +32 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palfia
7 years, 9 months ago (2013-03-04 04:14:21 UTC) #1
Michael Starzinger
LGTM. This CL is against the 3.16 branch, it should be landed on the bleeding_edge ...
7 years, 9 months ago (2013-03-04 10:16:46 UTC) #2
palfia
On 2013/03/04 10:16:46, Michael Starzinger wrote: > LGTM. This CL is against the 3.16 branch, ...
7 years, 9 months ago (2013-03-04 13:44:30 UTC) #3
palfia
7 years, 9 months ago (2013-03-04 14:26:38 UTC) #4
Message was sent while issue was closed.
Committed manually as r13803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698