Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

Issue 12383073: Add List.insert. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rename insertAt to insert.~ Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/lib/js_array.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
index 9b73f4080cbd0388225a53463aec53ec2e9cfde1..1339f09a822d9dc8988147b6d8ac0202645cbb06 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
@@ -27,6 +27,15 @@ class JSArray<E> implements List<E> {
return JS('var', r'#.splice(#, 1)[0]', this, index);
}
+ void insert(int index, E value) {
+ if (index is !int) throw new ArgumentError(index);
+ if (index < 0 || index > length) {
+ throw new RangeError.value(index);
+ }
+ checkGrowable(this, 'insert');
+ JS('void', r'#.splice(#, 0, #)', this, index, value);
+ }
+
E removeLast() {
checkGrowable(this, 'removeLast');
if (length == 0) throw new RangeError.value(-1);

Powered by Google App Engine
This is Rietveld 408576698