Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 12383060: cc: Remove texture scaling and clear edge texels of a layer. (Closed)

Created:
7 years, 9 months ago by brianderson
Modified:
7 years, 9 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

cc: Remove texture scaling and clear edge texels of a layer. Removes texture scaling and does the following instead: - Clears one texel inside the right/bottom edge of the content rect, as it may only be partially covered by the picture playback. - Also clears one texel outside the right/bottom edge of the content rect, as it may get blended in by linear filtering when zoomed in. The root layer is cleared to its background color. Other layers are cleared to transparent. BUG=178273 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185732

Patch Set 1 #

Patch Set 2 : rebase and expand base picture #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -46 lines) Patch
M cc/picture_layer.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M cc/picture_layer_tiling.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/picture_layer_tiling.cc View 4 chunks +10 lines, -36 lines 0 comments Download
M cc/picture_pile.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/picture_pile.cc View 1 2 chunks +12 lines, -2 lines 0 comments Download
M cc/picture_pile_base.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/picture_pile_base.cc View 1 3 chunks +4 lines, -1 line 0 comments Download
M cc/picture_pile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/picture_pile_impl.cc View 3 chunks +32 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
enne (OOO)
lgtm!
7 years, 9 months ago (2013-03-01 20:58:04 UTC) #1
enne (OOO)
Still lgtm.
7 years, 9 months ago (2013-03-01 22:49:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/12383060/12002
7 years, 9 months ago (2013-03-01 23:04:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brianderson@chromium.org/12383060/12002
7 years, 9 months ago (2013-03-02 16:25:03 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-02 18:00:42 UTC) #5
Message was sent while issue was closed.
Change committed as 185732

Powered by Google App Engine
This is Rietveld 408576698