Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 12383034: Add compressed/renamed new button style assets from sgabriel. (Closed)

Created:
7 years, 9 months ago by msw
Modified:
7 years, 9 months ago
Reviewers:
flackr, oshima
CC:
chromium-reviews, oshima+watch_chromium.org, Sebastien Gabriel, stromme
Visibility:
Public.

Description

Add compressed/renamed new button style assets from sgabriel. Simply adds the compressed and renamed asset files for use later. These will replace the current button style for dialogs, etc. I renamed the files to *[hover|pressed]_<position>.png for IMAGE_GRID: https://code.google.com/p/chromium/codesearch#chromium/src/ui/views/painter.h&l=22 I ran build/sanitize-png-files.sh for all files with default level (1). BUG=155363 TEST=none R=oshima@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-108 lines, --108 lines) Patch
A ui/resources/default_100_percent/common/button_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_hover_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_pressed_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ui/resources/default_100_percent/common/button_focused_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_focused_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_hover_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_pressed_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_100_percent/common/button_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_hover_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_pressed_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_focused_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_hover_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_center.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_pressed_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/resources/default_200_percent/common/button_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
msw
Hey Oshima, please take a look; thanks!
7 years, 9 months ago (2013-02-28 20:53:52 UTC) #1
oshima
lgtm
7 years, 9 months ago (2013-02-28 20:56:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/12383034/1
7 years, 9 months ago (2013-02-28 20:58:48 UTC) #3
commit-bot: I haz the power
Presubmit check for 12383034-1 failed and returned exit status 1. INFO:root:Found 108 file(s). Running presubmit ...
7 years, 9 months ago (2013-02-28 20:59:23 UTC) #4
msw
Hey Robert, can you explain this failed presubmit check? AFAICT, all the 1x assets are ...
7 years, 9 months ago (2013-02-28 21:05:49 UTC) #5
flackr
On 2013/02/28 21:05:49, msw wrote: > Hey Robert, can you explain this failed presubmit check? ...
7 years, 9 months ago (2013-02-28 22:20:06 UTC) #6
msw
7 years, 9 months ago (2013-02-28 22:23:56 UTC) #7
> because the commit queue doesn't properly handle binaries.
Right on, I guess I thought it'd be fine with NOTRY=true.
I'll dcommit; thanks for the info!

Powered by Google App Engine
This is Rietveld 408576698