Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: tools/bots/compiler.py

Issue 12383020: Add csp option to annotated steps for dart2js bots (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bots/bot.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 19201)
+++ tools/bots/compiler.py (working copy)
@@ -20,7 +20,7 @@
import bot
DART2JS_BUILDER = (
- r'dart2js-(linux|mac|windows)(-(jsshell))?-(debug|release)(-(checked|host-checked))?(-(host-checked))?(-(minified))?-?(\d*)-?(\d*)')
+ r'dart2js-(linux|mac|windows)(-(jsshell))?-(debug|release)(-(checked|host-checked))?(-(host-checked))?(-(minified))?(-(csp))?-?(\d*)-?(\d*)')
WEB_BUILDER = (
r'dart2js-(ie9|ie10|ff|safari|chrome|opera)-(win7|win8|mac10\.8|mac10\.7|linux)(-(all|html))?(-(\d+)-(\d+))?')
@@ -39,6 +39,7 @@
shard_index = None
total_shards = None
test_set = None
+ csp = None
dart2js_pattern = re.match(DART2JS_BUILDER, builder_name)
web_pattern = re.match(WEB_BUILDER, builder_name)
@@ -71,8 +72,10 @@
host_checked = True
if dart2js_pattern.group(10) == 'minified':
minified = True
- shard_index = dart2js_pattern.group(11)
- total_shards = dart2js_pattern.group(12)
+ if dart2js_pattern.group(12) == 'csp':
+ csp = True
+ shard_index = dart2js_pattern.group(13)
+ total_shards = dart2js_pattern.group(14)
else :
return None
@@ -91,7 +94,7 @@
return None
return bot.BuildInfo(compiler, runtime, mode, system, checked, host_checked,
minified, shard_index, total_shards, is_buildbot,
- test_set)
+ test_set, csp)
def NeedsXterm(compiler, runtime):
@@ -294,6 +297,8 @@
if build_info.minified: test_flags += ['--minified']
+ if build_info.csp: test_flags += ['--csp']
+
TestCompiler(build_info.runtime, build_info.mode, build_info.system,
list(test_flags), build_info.is_buildbot, build_info.test_set)
« no previous file with comments | « tools/bots/bot.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698